Fix !timer date parsing: strict mode, flexible formats, time-before-date#31
Merged
Conversation
- Accept time-before-date input (e.g. "14:45 12.3.2077") which previously silently set a wrong time due to lenient moment.js parsing - Parse only the first 1-2 tokens as date/time so an optional message after the date no longer breaks parsing in strict mode - Add single-digit day/month variants (D.M) alongside zero-padded (DD.MM) - Add reversed time-first formats (HH:mm DD.MM, HH:mm DD.MM.YYYY) - Add CI tests covering duration (5m, 2h), time-only, time-first date, date-first, and invalid input Fixes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20